Moved to one SubgraphManifest schema file per protocol #821

maoueh · 2022-01-28T19:00:56Z

This will make it easier to add new network and will improve error messages when someone will be using fields that do not exist on a specific network but does in other (temlates for example used in NEAR were given a bunch of errors like the support was possible while it should have displayed an error on the templates node itself).

Using templates on NEAR before this PR:

✔ Apply migrations
✖ Failed to load subgraph from ../graph-node-dev/subgraphs/near/data-source/testnet.yaml: Error in ../graph-node-dev/subgraphs/near/data-source/testnet.yaml:

  Path: templates > 0 > source
  No value provided

  Path: templates > 0 > mapping
  Unexpected key in map: receiptHandlers

  Path: templates > 0 > mapping > abis
  No value provided

And with this PR:

$ ./bin/graph build ../graph-node-dev/subgraphs/near/data-source/testnet.yaml
✖ Failed to load subgraph from ../graph-node-dev/subgraphs/near/data-source/testnet.yaml: Error in ../graph-node-dev/subgraphs/near/data-source/testnet.yaml:

  Path: /
  Unexpected key in map: templates

Jannis · 2022-01-28T20:28:20Z

One remark I have is that I can easily see Cross-Chain subgraphs becoming a thing and then the manifest would be a mix of data sources from different protocol.

schemas/ethereum.graphql

tests/cli/validation/invalid-manifest.stderr

src/protocols/index.js

src/subgraph.js

maoueh · 2022-02-03T16:37:14Z

Going to update all this today or tomorrow.

maoueh · 2022-02-07T15:48:23Z

PR updated.

This will make it easier to add new network and will improve error messages when someone will be using fields that do not exist on a specific network but does in other (`temlates` for example used in NEAR were given a bunch of errors like the support was possible while it should have displayed an error on the `templates` node itself). Using `templates` on NEAR before this PR: ``` ✔ Apply migrations ✖ Failed to load subgraph from ../graph-node-dev/subgraphs/near/data-source/testnet.yaml: Error in ../graph-node-dev/subgraphs/near/data-source/testnet.yaml: Path: templates > 0 > source No value provided Path: templates > 0 > mapping Unexpected key in map: receiptHandlers Path: templates > 0 > mapping > abis No value provided ``` And with this PR: ``` $ ./bin/graph build ../graph-node-dev/subgraphs/near/data-source/testnet.yaml ✖ Failed to load subgraph from ../graph-node-dev/subgraphs/near/data-source/testnet.yaml: Error in ../graph-node-dev/subgraphs/near/data-source/testnet.yaml: Path: / Unexpected key in map: templates ```

evaporei · 2022-02-08T12:35:10Z

tests/cli/validation.test.js

@@ -9,6 +9,14 @@ describe('Validation', () => {
      exitCode: 1,
    },
  )
+  cliTest(


Yaaay!! 🎉